[
https://issues.apache.org/jira/browse/BEAM-12856?focusedWorklogId=657774&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657774
]
ASF GitHub Bot logged work on BEAM-12856:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/21 00:24
Start Date: 30/Sep/21 00:24
Worklog Time Spent: 10m
Work Description: scwhittle commented on a change in pull request #15478:
URL: https://github.com/apache/beam/pull/15478#discussion_r718192527
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineDebugOptions.java
##########
@@ -230,6 +230,28 @@ public Dataflow create(PipelineOptions options) {
void setReaderCacheTimeoutSec(Integer value);
+ /** The max amount of time an UnboundedReader is consumed before
checkpointing. */
+ @Description(
+ "The max amount of time before an UnboundedReader is consumed before
checkpointing, in seconds.")
+ @Default.Integer(10)
+ Integer getUnboundedReaderMaxReadTimeSec();
+
+ void setUnboundedReaderMaxReadTimeSec(Integer value);
+
+ /** The max elements read from an UnboundedReader before checkpointing. */
+ @Description("The max elements read from an UnboundedReader before
checkpointing. ")
+ @Default.Integer(10 * 1000)
Review comment:
The value before was 10000. I went with writing as 10*1000 since with
that many zeros it is hard to eyeball.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 657774)
Time Spent: 1.5h (was: 1h 20m)
> Allow for configuration of unbounded reader max elements, read time etc in
> StreamingDataflowRunner
> --------------------------------------------------------------------------------------------------
>
> Key: BEAM-12856
> URL: https://issues.apache.org/jira/browse/BEAM-12856
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Sam Whittle
> Assignee: Sam Whittle
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently in WorkerCustomSources.java it is hard-coded to 10 seconds, 10k
> elements, with 1sec waiting for elements if none are available.
> There are cases where it would be beneficial to wait longer and process more
> data so it would be nice if this was controlled by pipeline option.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
