[
https://issues.apache.org/jira/browse/BEAM-12818?focusedWorklogId=657797&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657797
]
ASF GitHub Bot logged work on BEAM-12818:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/21 00:25
Start Date: 30/Sep/21 00:25
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#15416:
URL: https://github.com/apache/beam/pull/15416#discussion_r718788980
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
##########
@@ -522,16 +526,17 @@ protected static ResourceId
buildTemporaryFilename(ResourceId tempDirectory, Str
* Constructs a WriteOperation using the default strategy for generating a
temporary directory
* from the base output filename.
*
- * <p>Default is a uniquely named subdirectory of the provided
tempDirectory, e.g. if
- * tempDirectory is /path/to/foo/, the temporary directory will be
+ * <p>Without windowing, the default is a uniquely named subdirectory of
the provided
+ * tempDirectory, e.g. if tempDirectory is /path/to/foo/, the temporary
directory will be
* /path/to/foo/.temp-beam-$uuid.
*
+ * <p>With windowing, the default is to use tempDirectory directly.
Review comment:
Can we explain why we do this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 657797)
Time Spent: 1h 50m (was: 1h 40m)
> When writing to GCS, spread prefix of temporary files and reuse autoscaling
> of the temporary directory
> ------------------------------------------------------------------------------------------------------
>
> Key: BEAM-12818
> URL: https://issues.apache.org/jira/browse/BEAM-12818
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Reporter: Sam Whittle
> Assignee: Sam Whittle
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> When writing files using FileIO, the given temporary directory has a
> subdirectory created in it for each FileBasedSink. This is useful for
> non-windowed output where the temporary directory can be matched to delete
> leftover files that were lost during processing.
> However for windowed writes such subdirectories are unnecessary and cause a
> common prefix to be shared for the temporary files. Additionally this common
> prefix varies per job and thus the autoscaling for the previous prefix is no
> longer effective, see
> https://cloud.google.com/storage/docs/request-rate#randomness_after_sequential_prefixes_is_not_as_effective
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
