[
https://issues.apache.org/jira/browse/BEAM-11997?focusedWorklogId=658533&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658533
]
ASF GitHub Bot logged work on BEAM-11997:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/21 18:21
Start Date: 30/Sep/21 18:21
Worklog Time Spent: 10m
Work Description: MiguelAnzoWizeline commented on a change in pull
request #15549:
URL: https://github.com/apache/beam/pull/15549#discussion_r719653560
##########
File path:
sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
##########
@@ -334,94 +336,88 @@ public void setup() {
public void teardown() {
jedis.close();
}
- }
-
- private static class ReadKeysWithPattern extends BaseReadFn<String> {
- ReadKeysWithPattern(RedisConnectionConfiguration connectionConfiguration) {
- super(connectionConfiguration);
+ @GetInitialRestriction
+ public OffsetRange getInitialRestriction(@Element String pattern) {
+ return new OffsetRange(0, getKeyPatters(pattern).size());
}
@ProcessElement
- public void processElement(ProcessContext c) {
- ScanParams scanParams = new ScanParams();
- scanParams.match(c.element());
-
- String cursor = ScanParams.SCAN_POINTER_START;
- boolean finished = false;
- while (!finished) {
- ScanResult<String> scanResult = jedis.scan(cursor, scanParams);
- List<String> keys = scanResult.getResult();
- for (String k : keys) {
- c.output(k);
+ public void processElement(ProcessContext c,
RestrictionTracker<OffsetRange, Long> tracker) {
+ String pattern = c.element();
+ List<String> keys = getKeyPatters(pattern);
+ List<String> bundle = new ArrayList<>();
+ for (long i = tracker.currentRestriction().getFrom();
+ i < tracker.currentRestriction().getTo();
+ i++) {
+ if (tracker.tryClaim(i)) {
+ bundle.add(keys.get((int) i));
}
- cursor = scanResult.getCursor();
- if (cursor.equals(ScanParams.SCAN_POINTER_START)) {
- finished = true;
+ }
+ if (bundle.size() > 0) {
+ List<KV<String, String>> kvs = fetchAndFlush(bundle);
Review comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 658533)
Time Spent: 1h 20m (was: 1h 10m)
> Implement RedisIO on top of Splittable DoFn
> -------------------------------------------
>
> Key: BEAM-11997
> URL: https://issues.apache.org/jira/browse/BEAM-11997
> Project: Beam
> Issue Type: Improvement
> Components: io-java-redis
> Reporter: Boyuan Zhang
> Assignee: Miguel Anzo
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
