[
https://issues.apache.org/jira/browse/BEAM-12963?focusedWorklogId=658571&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658571
]
ASF GitHub Bot logged work on BEAM-12963:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/21 19:23
Start Date: 30/Sep/21 19:23
Worklog Time Spent: 10m
Work Description: damondouglas commented on a change in pull request
#15626:
URL: https://github.com/apache/beam/pull/15626#discussion_r719694532
##########
File path: playground/frontend/lib/modules/sdk/components/sdk_selector.dart
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import 'package:flutter/material.dart';
+import 'package:playground/config/theme.dart';
+import 'package:playground/modules/sdk/models/sdk.dart';
+
+typedef void SetSdk(SDK sdk);
+
+class SDKSelector extends StatelessWidget {
+ final SDK sdk;
+ final SetSdk setSdk;
+
+ const SDKSelector({Key? key, required this.sdk, required this.setSdk})
+ : super(key: key);
+
+ @override
+ Widget build(BuildContext context) {
+ return Container(
+ padding: const EdgeInsets.symmetric(
+ vertical: 0.0,
+ horizontal: 16.0,
+ ),
+ decoration: BoxDecoration(
+ color: ThemeColors.greyColor(context),
+ borderRadius: BorderRadius.circular(8.0),
+ ),
+ child: DropdownButtonHideUnderline(
+ child: DropdownButton<SDK>(
+ value: sdk,
+ icon: const Icon(Icons.keyboard_arrow_down),
+ iconSize: 24,
+ elevation: 1,
+ borderRadius: BorderRadius.circular(8.0),
+ alignment: Alignment.bottomCenter,
+ onChanged: (SDK? newSdk) {
+ if (newSdk != null) {
+ setSdk(newSdk);
Review comment:
I think this could be improved by using a `Stateful` widget and using:
```dart
setState(() {
this.sdk = ...
});
```
This would require redesigning the constructor of this class. The
`setState` is great if knowledge of the state is internal to the `Stateful`
widget. If knowledge of state is needed outside this `Stateful` widget, there
are many options depending on whether these are sibling, child or widgets
somewhere else in the Widget tree. The easiest for parent/child relationships
are using the
https://api.flutter.dev/flutter/widgets/InheritedWidget-class.html.
I've been able to get away with more complex state sharing without using the
popular [provider](https://pub.dev/packages/provider) package but I would have
to find notes on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 658571)
Time Spent: 1h 20m (was: 1h 10m)
> [Playground] Implement SDK selector
> -----------------------------------
>
> Key: BEAM-12963
> URL: https://issues.apache.org/jira/browse/BEAM-12963
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Aydar Farrakhov
> Assignee: Aydar Farrakhov
> Priority: P3
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
