[ 
https://issues.apache.org/jira/browse/BEAM-10917?focusedWorklogId=658619&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658619
 ]

ASF GitHub Bot logged work on BEAM-10917:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Sep/21 21:06
            Start Date: 30/Sep/21 21:06
    Worklog Time Spent: 10m 
      Work Description: kmjung commented on a change in pull request #15602:
URL: https://github.com/apache/beam/pull/15602#discussion_r719768878



##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1914,11 +2310,30 @@ class ReadFromBigQuery(PTransform):
         to create and delete tables within the given dataset. Dataset name
         should *not* start with the reserved prefix `beam_temp_dataset_`.
    """
+  class Method(object):
+    EXPORT = 'EXPORT'  #  This is currently the default.
+    DIRECT_READ = 'DIRECT_READ'

Review comment:
       I'm not sure that I have a sense of what Beam values here (consistency 
across languages vs. consistency with external naming). I guess my slight 
preference would be for the former, which would mean carrying over the 
`DIRECT_READ` name. @satybald @pabloem @chamikaramj what do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 658619)
    Time Spent: 33.5h  (was: 33h 20m)

> Implement a BigQuery bounded source using the BigQuery storage API
> ------------------------------------------------------------------
>
>                 Key: BEAM-10917
>                 URL: https://issues.apache.org/jira/browse/BEAM-10917
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-py-gcp
>            Reporter: Kenneth Jung
>            Assignee: Vachan Shetty
>            Priority: P3
>          Time Spent: 33.5h
>  Remaining Estimate: 0h
>
> The Java SDK contains a bounded source implementation which uses the BigQuery 
> storage API to read from BigQuery. We should implement the same for Python.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to