[ 
https://issues.apache.org/jira/browse/BEAM-12991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424045#comment-17424045
 ] 

Brian Hulette commented on BEAM-12991:
--------------------------------------

I think a good first step here would be to enable the check and add 'from' 
keyword in most places, but disable it in places where the exception already 
includes information about the underlying error.

[~benglez] do you have the bandwidth to do that? Or would it be a lot more work 
than what you already started to do for BEAM-11516

> Fix pylint warning: Consider explicitly re-raising using the 'from' keyword 
> (raise-missing-from)
> ------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-12991
>                 URL: https://issues.apache.org/jira/browse/BEAM-12991
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-py-core, testing
>            Reporter: Benjamin Gonzalez
>            Priority: P2
>
> The warning "raise-missing-from" from pylint (2.11.1) is temporarily disabled 
> because in many places already exists logic to inform the user about the 
> underlying error, so it's redundant to use the "{{from"}} syntax as well.
> The "form" syntax is preferable, but we need to look over the exceptions to 
> dedupe this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to