[
https://issues.apache.org/jira/browse/BEAM-12978?focusedWorklogId=661237&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-661237
]
ASF GitHub Bot logged work on BEAM-12978:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/21 22:46
Start Date: 06/Oct/21 22:46
Worklog Time Spent: 10m
Work Description: ihji commented on a change in pull request #15606:
URL: https://github.com/apache/beam/pull/15606#discussion_r723731416
##########
File path:
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
##########
@@ -371,6 +371,20 @@ default InputT createInput(Pipeline p, Map<String,
PCollection<?>> inputs) {
return extractOutputs(
Pipeline.applyTransform(name, createInput(p, inputs),
getTransform(spec)));
}
+
+ default List<String> getDependencies(PipelineOptions options) {
Review comment:
I thought we can use either
`ExpansionServiceRegistrar(TransformProvider)` or
`ExternalTransformRegistrar(ExternalTransformBuilder)`. Anyhow, it looks like
`ExternalTransformBuilder` is the one used with existing Java external IO
transforms.
I also added the new method to `ExternalTransformBuilder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 661237)
Time Spent: 3.5h (was: 3h 20m)
> Customizable dependency for Java external transform
> ---------------------------------------------------
>
> Key: BEAM-12978
> URL: https://issues.apache.org/jira/browse/BEAM-12978
> Project: Beam
> Issue Type: Improvement
> Components: cross-language
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Customized dependency for Java external transform
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
