[
https://issues.apache.org/jira/browse/BEAM-12971?focusedWorklogId=661682&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-661682
]
ASF GitHub Bot logged work on BEAM-12971:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/21 14:52
Start Date: 07/Oct/21 14:52
Worklog Time Spent: 10m
Work Description: damondouglas commented on a change in pull request
#15660:
URL: https://github.com/apache/beam/pull/15660#discussion_r724259256
##########
File path: playground/backend/internal/executors/executor.go
##########
@@ -13,19 +13,85 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-// Interface for all executors (Java/Python/Go/SCIO)
+// Package executors
package executors
-type executor interface {
- // Validate validates executable file.
- // Return result of validation (true/false) and error if it occurs
- Validate(filePath string) (bool, error)
+import (
+ pb "beam.apache.org/playground/backend/internal/api"
+ "beam.apache.org/playground/backend/internal/fs_tool"
+ "fmt"
+ "os/exec"
+)
- // Compile compiles executable file.
- // Return error if it occurs
- Compile(filePath string) error
+type validatorWithArgs struct {
+ validator func(filePath string, args ...interface{}) error
Review comment:
This is not blocking of the PR but I think this might be a good
candidate for an interface in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 661682)
Time Spent: 40m (was: 0.5h)
> Compile Java code
> -----------------
>
> Key: BEAM-12971
> URL: https://issues.apache.org/jira/browse/BEAM-12971
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Ilya Kozyrev
> Assignee: Daria Malkova
> Priority: P3
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The server app should be able to compile java code.
> Assume that all required dependencies are already installed in the runtime
> environment.
> Need to implement Compile method for Java executor
> As an output jar file should be located in local FS.
> Compile method should handle errors from a compilation
> The server should send a compilation result the to frontend
> We should cover all methods and functions with unit tests
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
