[ 
https://issues.apache.org/jira/browse/BEAM-6773?focusedWorklogId=213667&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213667
 ]

ASF GitHub Bot logged work on BEAM-6773:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Mar/19 10:01
            Start Date: 15/Mar/19 10:01
    Worklog Time Spent: 10m 
      Work Description: stankiewicz commented on pull request #8024: 
[BEAM-6773] Add ValueProvider to CassandraIO.Read
URL: https://github.com/apache/beam/pull/8024#discussion_r265915739
 
 

 ##########
 File path: 
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
 ##########
 @@ -131,16 +132,16 @@ private CassandraIO() {}
   @AutoValue
   public abstract static class Read<T> extends PTransform<PBegin, 
PCollection<T>> {
     @Nullable
-    abstract List<String> hosts();
+    abstract ValueProvider<String> hosts();
 
 Review comment:
   DataflowSDK doesn't handle it properly at this moment, there is 
[bug](https://github.com/GoogleCloudPlatform/DataflowJavaSDK/issues/632) so I 
would prefer to push it as is and in the meantime will try to investigate SDK 
project. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 213667)
            Time Spent: 2h 20m  (was: 2h 10m)
    Remaining Estimate: 21h 40m  (was: 21h 50m)

> Add ValueProvider to CassandraIO
> --------------------------------
>
>                 Key: BEAM-6773
>                 URL: https://issues.apache.org/jira/browse/BEAM-6773
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-cassandra
>            Reporter: Radosław Stankiewicz
>            Assignee: Radosław Stankiewicz
>            Priority: Major
>              Labels: features, triaged
>   Original Estimate: 24h
>          Time Spent: 2h 20m
>  Remaining Estimate: 21h 40m
>
> I want to add ValueProviders in Cassandra, starting with Read.
> Write and Delete will be added later when I succeed with that.
> ValueProvider should be added for all primitive types which then is easy to 
> configure with DataflowTemplates.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to