[
https://issues.apache.org/jira/browse/BEAM-11275?focusedWorklogId=663007&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663007
]
ASF GitHub Bot logged work on BEAM-11275:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/21 22:41
Start Date: 08/Oct/21 22:41
Worklog Time Spent: 10m
Work Description: casassg commented on a change in pull request #15105:
URL: https://github.com/apache/beam/pull/15105#discussion_r725348262
##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -463,6 +465,23 @@ def _download_file(from_url, to_path):
_LOGGER.info('Failed to download Artifact from %s', from_url)
raise
else:
+ try:
+ read_handle = FileSystems.open(from_url)
Review comment:
to avoid decompression: `compression_type=CompressionTypes.UNCOMPRESSED`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 663007)
Time Spent: 14h (was: 13h 50m)
> Support GCS files for extra_requirements argument in Python Beam portable
> runners
> ---------------------------------------------------------------------------------
>
> Key: BEAM-11275
> URL: https://issues.apache.org/jira/browse/BEAM-11275
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Gerard Casas Saez
> Assignee: Calvin Leung
> Priority: P2
> Time Spent: 14h
> Remaining Estimate: 0h
>
> Currently Portable runners only support locally available files for adding
> dependencies on remote workers. This can be seen in
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/stager.py#L429
> as it uses shutil.copyfile when it detects file is remote and it is not http.
> An easy extension would be to extend _is_remote_path in Stager to detect if
> the path matches any filesystem and if it does the avoid downloading and let
> it be copied afterwards.
> Acceptance criteria:
> - `extra_package` can be a GCS path instead of requiring it to be local only.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
