[
https://issues.apache.org/jira/browse/BEAM-6730?focusedWorklogId=213692&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213692
]
ASF GitHub Bot logged work on BEAM-6730:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/19 10:52
Start Date: 15/Mar/19 10:52
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #7875: [BEAM-6730] Expose
Java SDK's GenerateSequence in Python
URL: https://github.com/apache/beam/pull/7875#discussion_r265919540
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingPortablePipelineTranslator.java
##########
@@ -192,18 +204,28 @@ public StreamExecutionEnvironment
getExecutionEnvironment() {
translatorMap.put(PTransformTranslation.FLATTEN_TRANSFORM_URN,
this::translateFlatten);
translatorMap.put(PTransformTranslation.GROUP_BY_KEY_TRANSFORM_URN,
this::translateGroupByKey);
translatorMap.put(PTransformTranslation.IMPULSE_TRANSFORM_URN,
this::translateImpulse);
- translatorMap.put(STREAMING_IMPULSE_TRANSFORM_URN,
this::translateStreamingImpulse);
translatorMap.put(
PTransformTranslation.ASSIGN_WINDOWS_TRANSFORM_URN,
this::translateAssignWindows);
translatorMap.put(ExecutableStage.URN, this::translateExecutableStage);
translatorMap.put(PTransformTranslation.RESHUFFLE_URN,
this::translateReshuffle);
+ // TODO Legacy transforms which need to be removed
+ // Consider removing now that timers are supported
+ translatorMap.put(STREAMING_IMPULSE_TRANSFORM_URN,
this::translateStreamingImpulse);
+ // Remove once Reads can be wrapped in SDFs
+ translatorMap.put(PTransformTranslation.READ_TRANSFORM_URN,
this::translateRead);
+
this.urnToTransformTranslator = translatorMap.build();
}
@Override
public Set<String> knownUrns() {
- return urnToTransformTranslator.keySet();
+ // Do not expose Read as a known URN because we only want to support Read
Review comment:
In portable pipelines Reads are executed via an environment, i.e. in the SDK
harness via ExecutableStage. So they are not native. If we expose the Read URN
here, we will have to deal with translating Python and Java Reads natively.
However, we can only translate Java Reads natively.
Besides the code here being an optimization to execute without the Java SDK
harness, we also want to support unbounded reads which are not supported via
the SDK harness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 213692)
Time Spent: 7.5h (was: 7h 20m)
> Expose Java transforms (specifically IO) in other SDKs
> ------------------------------------------------------
>
> Key: BEAM-6730
> URL: https://issues.apache.org/jira/browse/BEAM-6730
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink, sdk-java-core, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> Since https://github.com/apache/beam/pull/7316 we can reference external
> transforms which are transforms only available in a "foreign" SDKs. This
> allows us to fill the gap in terms of missing transforms in the Python and Go
> SDK, specifically IO transforms.
> We can start collecting/exposing transforms that Beam users need. The
> following transforms could be interesting:
> - KafkaIO / KinesisIO
> - CassandraIO / ElasticserchIO / Hbase / Redis
> - JDBC
> - S3 file system
> - GenerateSequence
> See also https://s.apache.org/beam-cross-language-io and BEAM-6485.
> CC [~robertwb] [~chamikara] [~thw]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
