[ 
https://issues.apache.org/jira/browse/BEAM-13038?focusedWorklogId=664212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664212
 ]

ASF GitHub Bot logged work on BEAM-13038:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Oct/21 18:32
            Start Date: 12/Oct/21 18:32
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on pull request #15711:
URL: https://github.com/apache/beam/pull/15711#issuecomment-941273979


   R: @kileys @TheNeuralBit 
   
   This contains a bunch of clean-up since modifying a PTransformRunnerFactory 
parameter was annoying and I have a few that are coming up with a separate 
change so I wanted to get this out of the way since it is a large but trivial 
conversion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 664212)
    Time Spent: 20m  (was: 10m)

> PTransformRunnerFactory should use a context object to pass parameters.
> -----------------------------------------------------------------------
>
>                 Key: BEAM-13038
>                 URL: https://issues.apache.org/jira/browse/BEAM-13038
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-harness
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>            Priority: P3
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> PTransformRunnerFactory should expose a context object instead of requiring 
> all the parameters to be enumerated.
> Passing each parameter separately worked well when there were only a few but 
> as the list grows, it becomes more difficult to make changes easily without 
> needing to make changes to many unrelated classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to