[
https://issues.apache.org/jira/browse/BEAM-12931?focusedWorklogId=664795&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664795
]
ASF GitHub Bot logged work on BEAM-12931:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Oct/21 17:34
Start Date: 13/Oct/21 17:34
Worklog Time Spent: 10m
Work Description: laraschmidt commented on a change in pull request
#15540:
URL: https://github.com/apache/beam/pull/15540#discussion_r728302215
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java
##########
@@ -437,19 +437,24 @@ public Instant timestamp() {
@SuppressWarnings("deprecation") // Allowed Skew is deprecated for users,
but must be respected
private void checkTimestamp(Instant timestamp) {
- // The documentation of getAllowedTimestampSkew explicitly permits
Long.MAX_VALUE to be used
- // for infinite skew. Defend against underflow in that case for
timestamps before the epoch
- if (fn.getAllowedTimestampSkew().getMillis() != Long.MAX_VALUE
- &&
timestamp.isBefore(elem.getTimestamp().minus(fn.getAllowedTimestampSkew()))) {
+ Instant lowerBound;
+ Instant upperBound = BoundedWindow.TIMESTAMP_MAX_VALUE;
+ try {
+ lowerBound = elem.getTimestamp().minus(fn.getAllowedTimestampSkew());
+ } catch (ArithmeticException e) {
+ lowerBound = BoundedWindow.TIMESTAMP_MIN_VALUE;
+ }
+ if (timestamp.isBefore(lowerBound) || timestamp.isAfter(upperBound)) {
Review comment:
done
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java
##########
@@ -1190,13 +1195,24 @@ public Timer withOutputTimestamp(Instant
outputTimestamp) {
* </ul>
*/
private void setAndVerifyOutputTimestamp() {
-
if (outputTimestamp != null) {
- checkArgument(
- !outputTimestamp.isBefore(elementInputTimestamp),
- "output timestamp %s should be after input message timestamp or
output timestamp of firing timers %s",
- outputTimestamp,
- elementInputTimestamp);
+ Instant lowerBound;
+ Instant upperBound = BoundedWindow.TIMESTAMP_MAX_VALUE;
+ try {
+ lowerBound =
elementInputTimestamp.minus(fn.getAllowedTimestampSkew());
+ } catch (ArithmeticException e) {
+ lowerBound = BoundedWindow.TIMESTAMP_MIN_VALUE;
+ }
+ if (outputTimestamp.isBefore(lowerBound) ||
outputTimestamp.isAfter(upperBound)) {
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 664795)
Time Spent: 3h 20m (was: 3h 10m)
> Timer.setOutputTimestamp doesn't take into account for
> DoFn#getAllowedTimestampSkew()
> -------------------------------------------------------------------------------------
>
> Key: BEAM-12931
> URL: https://issues.apache.org/jira/browse/BEAM-12931
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Lara Schmidt
> Assignee: Lara Schmidt
> Priority: P2
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> A DoFn may emit elements with a timestamp up to
> DoFn#getAllowedTimestampSkew() before the current element's timestamp.
> However getAllowedTimestampSkew is not properly accounted for in looking at
> the output timestamp of a timer.
> Context:
> [https://lists.apache.org/thread.html/r7554658114ddde86c5d82e1c39fe7e1ef587fe926b8e406d1130d501%40%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
