[
https://issues.apache.org/jira/browse/BEAM-12907?focusedWorklogId=665081&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665081
]
ASF GitHub Bot logged work on BEAM-12907:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Oct/21 18:42
Start Date: 13/Oct/21 18:42
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #15587:
URL: https://github.com/apache/beam/pull/15587#discussion_r727577054
##########
File path: sdks/python/tox.ini
##########
@@ -249,3 +249,14 @@ commands =
/bin/sh -c "pip freeze | grep -E '(pyarrow|numpy)'"
# TODO(BEAM-12985): Running run_pytest.sh with -m causes us to run all the
tests twice
{toxinidir}/scripts/run_pytest.sh {envname} "{posargs}" '-m uses_pyarrow'
+
+[testenv:py{36,37,38}-pandas-{11,12,13}]
+deps =
+ 11: pandas>=1.1.0,<1.2.0
+ 12: pandas>=1.2.0,<1.3.0
+ 13: pandas>=1.3.0,<1.4.0
+commands =
+ # Log pandas and numpy version for debugging
+ /bin/sh -c "pip freeze | grep -E '(pandas|numpy)'"
+ # Run all DataFrame API unit tests
+ {toxinidir}/scripts/run_pytest.sh {envname} 'apache_beam/dataframe'
Review comment:
Do we need to do something similar as
https://github.com/apache/beam/pull/15693?
##########
File path: sdks/python/tox.ini
##########
@@ -249,3 +249,14 @@ commands =
/bin/sh -c "pip freeze | grep -E '(pyarrow|numpy)'"
# TODO(BEAM-12985): Running run_pytest.sh with -m causes us to run all the
tests twice
{toxinidir}/scripts/run_pytest.sh {envname} "{posargs}" '-m uses_pyarrow'
+
+[testenv:py{36,37,38}-pandas-{11,12,13}]
+deps =
+ 11: pandas>=1.1.0,<1.2.0
+ 12: pandas>=1.2.0,<1.3.0
+ 13: pandas>=1.3.0,<1.4.0
+commands =
+ # Log pandas and numpy version for debugging
+ /bin/sh -c "pip freeze | grep -E '(pandas|numpy)'"
+ # Run all DataFrame API unit tests
+ {toxinidir}/scripts/run_pytest.sh {envname} 'apache_beam/dataframe'
Review comment:
Do we need to do something similar as
https://github.com/apache/beam/pull/15693?
If not, please resolve merge and then LGTM.
##########
File path: sdks/python/test-suites/tox/py38/build.gradle
##########
@@ -41,12 +41,12 @@ testPy38Cython.mustRunAfter testPython38,
testPy38CloudCoverage
preCommitPy38.dependsOn "testPy38pyarrow-$version"
}
-toxTask "testPy38pandas-11", "py38-pandas-11"
-toxTask "testPy38pandas-12", "py38-pandas-12"
-toxTask "testPy38pandas-13", "py38-pandas-13"
-test.dependsOn "testPy38pandas-11"
-test.dependsOn "testPy38pandas-12"
-test.dependsOn "testPy38pandas-13"
+(1..3).each {minor_version ->
Review comment:
nit: even though the old version had what seemed like duplicates, it was
much more code search friendly.
##########
File path: sdks/python/test-suites/tox/py38/build.gradle
##########
@@ -41,12 +41,12 @@ testPy38Cython.mustRunAfter testPython38,
testPy38CloudCoverage
preCommitPy38.dependsOn "testPy38pyarrow-$version"
}
-toxTask "testPy38pandas-11", "py38-pandas-11"
-toxTask "testPy38pandas-12", "py38-pandas-12"
-toxTask "testPy38pandas-13", "py38-pandas-13"
-test.dependsOn "testPy38pandas-11"
-test.dependsOn "testPy38pandas-12"
-test.dependsOn "testPy38pandas-13"
+(1..3).each {minor_version ->
Review comment:
nit: even though the old version had what seemed like duplicate code, it
was much more code search friendly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 665081)
Time Spent: 6.5h (was: 6h 20m)
> Run DataFrame unit tests with multiple minor pandas versions
> ------------------------------------------------------------
>
> Key: BEAM-12907
> URL: https://issues.apache.org/jira/browse/BEAM-12907
> Project: Beam
> Issue Type: Improvement
> Components: dsl-dataframe
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> It's ok to run dataframe integration tests with just the latest, but we
> should run all of the unit tests with every minor pandas version. frames_test
> in particular has the potential to break on older versions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
