[
https://issues.apache.org/jira/browse/BEAM-12769?focusedWorklogId=665938&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665938
]
ASF GitHub Bot logged work on BEAM-12769:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/21 00:46
Start Date: 17/Oct/21 00:46
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #15690:
URL: https://github.com/apache/beam/pull/15690#discussion_r730014532
##########
File path:
sdks/java/testing/expansion-service/src/test/resources/test_expansion_service_allowlist.yaml
##########
@@ -0,0 +1,26 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+version: v1
+allowedClasses:
Review comment:
While there are security concerns for hosted/shared expansion services,
the common usecase is that the user running the expansion service is the same
user running the Python code. Even if adding to the allow list is simple, it's
an extra, out-of-line step for ad-hoc use of this functionality.
##########
File path:
sdks/java/testing/expansion-service/src/test/resources/test_expansion_service_allowlist.yaml
##########
@@ -0,0 +1,26 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+version: v1
+allowedClasses:
Review comment:
We can take this up elsewhere; I don't want to block this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 665938)
Time Spent: 39h 50m (was: 39h 40m)
> Adds support for expanding a Java cross-language transform using the class
> name and builder methods
> ---------------------------------------------------------------------------------------------------
>
> Key: BEAM-12769
> URL: https://issues.apache.org/jira/browse/BEAM-12769
> Project: Beam
> Issue Type: Improvement
> Components: cross-language, sdk-java-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: P1
> Fix For: 2.34.0
>
> Time Spent: 39h 50m
> Remaining Estimate: 0h
>
> Please see here for the design:
> https://docs.google.com/document/d/1ECXSWicE31K-vSxdb4qL6UcmovOAWvE-ZHFT3NTM654/edit?usp=sharing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
