[ 
https://issues.apache.org/jira/browse/BEAM-13074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430002#comment-17430002
 ] 

Julien Tournay edited comment on BEAM-13074 at 10/18/21, 2:22 PM:
------------------------------------------------------------------

I think the issue comes from `FlinkMetricContainer`. You can see 
[here|https://github.com/apache/beam/blob/master/runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/FlinkMetricContainer.java#L64]
 that `FlinkMetricContainer` has a `private final MetricsContainerStepMap 
metricsContainer` that is supposed to hold the metrics (`updateMetrics` starts 
by getting the metrics from `metricsContainer`).

Unless I'm missing something, I don’t see anything actually appending values to 
`metricsContainer` so no metric can actually be "cached".

Assuming that's indeed the issue, it was introduced by 
[https://github.com/apache/beam/pull/10415], 2 years ago.


was (Author: jto):
I think the issue comes from `FlinkMetricContainer`. You can see 
[here|https://github.com/apache/beam/blob/master/runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/FlinkMetricContainer.java#L64]
 that `FlinkMetricContainer` has a `private final MetricsContainerStepMap 
metricsContainer` that is supposed to hold the metrics (`updateMetrics` starts 
by getting the metrics from `metricsContainer`).

Unless I'm missing something, I don’t see anything actually appending values to 
`metricsContainer` so no metric can actually be "cached".

Assuming that's indeed the issue, it was introduced by 
[https://github.com/apache/beam/pull/10415], over 2 years ago.

> Metrics are not reported by the Flink runner
> --------------------------------------------
>
>                 Key: BEAM-13074
>                 URL: https://issues.apache.org/jira/browse/BEAM-13074
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-flink
>    Affects Versions: 2.33.0
>            Reporter: Julien Tournay
>            Priority: P1
>
> When running a job using the Flink runner,  metrics are not reported.
> See [https://github.com/jto/beam-flink-broken-metrics] for a minimal example.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to