[
https://issues.apache.org/jira/browse/BEAM-13079?focusedWorklogId=667113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667113
]
ASF GitHub Bot logged work on BEAM-13079:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/21 16:31
Start Date: 19/Oct/21 16:31
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#15748:
URL: https://github.com/apache/beam/pull/15748#discussion_r732048522
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerTransformRegistrar.java
##########
@@ -51,13 +51,13 @@
@Experimental(Kind.PORTABILITY)
@AutoService(ExternalTransformRegistrar.class)
public class SpannerTransformRegistrar implements ExternalTransformRegistrar {
- public static final String INSERT_URN =
"beam:external:java:spanner:insert:v1";
- public static final String UPDATE_URN =
"beam:external:java:spanner:update:v1";
- public static final String REPLACE_URN =
"beam:external:java:spanner:replace:v1";
+ public static final String INSERT_URN =
"beam:transform:org.apache.beam:spanner_read:v1";
Review comment:
```suggestion
public static final String INSERT_URN =
"beam:transform:org.apache.beam:spanner_insert:v1";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 667113)
Time Spent: 1h (was: 50m)
> Update Beam cross-language transform URNs to use the new convention
> -------------------------------------------------------------------
>
> Key: BEAM-13079
> URL: https://issues.apache.org/jira/browse/BEAM-13079
> Project: Beam
> Issue Type: Improvement
> Components: cross-language
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: P2
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Approved proposal:
> [https://docs.google.com/document/d/1JOHPBNv6x6ziMdwr_96EPSP-Bx7C4IrLU1j267MSCts/edit?usp=sharing]
>
> Dev list thread:
> [https://lists.apache.org/thread.html/r02a9d9c0b56c997517fc4b858ae56c220f7d8a8230f9be27d1ba36f4%40%3Cdev.beam.apache.org%3E]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
