[
https://issues.apache.org/jira/browse/BEAM-13023?focusedWorklogId=667373&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667373
]
ASF GitHub Bot logged work on BEAM-13023:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Oct/21 00:16
Start Date: 20/Oct/21 00:16
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #15721:
URL: https://github.com/apache/beam/pull/15721#discussion_r732328829
##########
File path: playground/backend/internal/cache/cache.go
##########
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package cache
+
+import (
+ "context"
+ "github.com/google/uuid"
+ "os"
+ "time"
+)
+
+type SubKey string
+
+const (
Review comment:
Can you add a comment here detailing that these are the kinds of values
and their types please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 667373)
Time Spent: 1h (was: 50m)
> Implement Redis cache for pipelines' states
> -------------------------------------------
>
> Key: BEAM-13023
> URL: https://issues.apache.org/jira/browse/BEAM-13023
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Artur Khanin
> Assignee: Aydar Zaynutdinov
> Priority: P3
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The backend should be able to use Redis to:
> * save cache value by *pipelineId* and one more *sub-key* as a nested
> structure
> * get cache by *pipelineId* and one more *sub-key*
> * set time expiration for *pipelineId* key
>
> Inner Redis client should be an implementation of *Cache* interface, so that
> it could be used like *LocalCache*.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
