[
https://issues.apache.org/jira/browse/BEAM-11275?focusedWorklogId=667430&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667430
]
ASF GitHub Bot logged work on BEAM-11275:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Oct/21 03:42
Start Date: 20/Oct/21 03:42
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #15105:
URL: https://github.com/apache/beam/pull/15105#issuecomment-947298373
> Good idea. I added tests for all 3 cases in `Stager._download_file`. It is
also working on wordcount example and our internal usage. @aaltay Please let me
know what else you need from me! Otherwise seems like it's ready to be merged.
Thanks.
Thank you and this is excellent. Could you please fix the formatting issue
on the new file?
You can follow this:
https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-LintandFormattingChecks
Or apply the delta from the failed test output manually:
https://ci-beam.apache.org/job/beam_PreCommit_PythonFormatter_Commit/8385/console
(delta near the bottom of the log.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 667430)
Time Spent: 16h 20m (was: 16h 10m)
> Support GCS files for extra_requirements argument in Python Beam portable
> runners
> ---------------------------------------------------------------------------------
>
> Key: BEAM-11275
> URL: https://issues.apache.org/jira/browse/BEAM-11275
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Gerard Casas Saez
> Assignee: Calvin Leung
> Priority: P2
> Time Spent: 16h 20m
> Remaining Estimate: 0h
>
> Currently Portable runners only support locally available files for adding
> dependencies on remote workers. This can be seen in
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/stager.py#L429
> as it uses shutil.copyfile when it detects file is remote and it is not http.
> An easy extension would be to extend _is_remote_path in Stager to detect if
> the path matches any filesystem and if it does the avoid downloading and let
> it be copied afterwards.
> Acceptance criteria:
> - `extra_package` can be a GCS path instead of requiring it to be local only.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
