[ 
https://issues.apache.org/jira/browse/BEAM-13008?focusedWorklogId=667909&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667909
 ]

ASF GitHub Bot logged work on BEAM-13008:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Oct/21 18:39
            Start Date: 20/Oct/21 18:39
    Worklog Time Spent: 10m 
      Work Description: pabloem commented on a change in pull request #15761:
URL: https://github.com/apache/beam/pull/15761#discussion_r733013050



##########
File path: settings.gradle.kts
##########
@@ -187,6 +187,9 @@ include(":sdks:java:testing:load-tests")
 include(":sdks:java:testing:test-utils")
 include(":sdks:java:testing:tpcds")
 include(":sdks:java:testing:watermarks")
+include(":playground")
+include(":playground:backend")
+include(":playground:frontend")

Review comment:
       can you add these in alphabetical order? this would make it appear 
before sdks, since p goes before s : )

##########
File path: build.gradle.kts
##########
@@ -249,6 +247,17 @@ task("goIntegrationTests") {
   dependsOn(":runners:google-cloud-dataflow-java:worker:shadowJar")
 }
 
+task("playgroundPreCommit") {
+  dependsOn(":playground:backend:format")

Review comment:
       would format modify the code? if so, then it should not be part of 
precommit




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 667909)
    Time Spent: 50m  (was: 40m)

> [Playground] Add build.gradle.kts
> ---------------------------------
>
>                 Key: BEAM-13008
>                 URL: https://issues.apache.org/jira/browse/BEAM-13008
>             Project: Beam
>          Issue Type: Sub-task
>          Components: beam-playground
>            Reporter: Damon Douglas
>            Assignee: Damon Douglas
>            Priority: P3
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The purpose of this task is to establish a build.gradle.kts in the playground 
> directory and related sub-directories where needed.  This will enable the 
> playground project to be consistent with the rest of the Apache Beam project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to