[ 
https://issues.apache.org/jira/browse/BEAM-13066?focusedWorklogId=668022&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668022
 ]

ASF GitHub Bot logged work on BEAM-13066:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Oct/21 22:15
            Start Date: 20/Oct/21 22:15
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #15757:
URL: https://github.com/apache/beam/pull/15757#discussion_r733185343



##########
File path: sdks/python/apache_beam/transforms/combiners.py
##########
@@ -377,6 +381,9 @@ def push(hp, e):
     else:
       heap = []
       for bundle in bundles:
+        # See above.

Review comment:
       ```suggestion
           # TODO(robertwb): Remove once legacy dataflow correctly handles
           # coders with combiner packing and/or is deprecated.
   ```
   
   See above is likely to become vague.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 668022)
    Time Spent: 2h  (was: 1h 50m)

> IterableCoder often returns a List
> ----------------------------------
>
>                 Key: BEAM-13066
>                 URL: https://issues.apache.org/jira/browse/BEAM-13066
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>            Priority: P2
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> This leads to cases where operations like `len` and indexing only work in 
> tests, or for small data, but can fail otherwise. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to