[
https://issues.apache.org/jira/browse/BEAM-13095?focusedWorklogId=668863&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668863
]
ASF GitHub Bot logged work on BEAM-13095:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/21 09:47
Start Date: 22/Oct/21 09:47
Worklog Time Spent: 10m
Work Description: AydarZaynutdinov commented on a change in pull request
#15770:
URL: https://github.com/apache/beam/pull/15770#discussion_r734395731
##########
File path: playground/backend/internal/fs_tool/java_fs.go
##########
@@ -21,14 +21,14 @@ import (
)
const (
- javaBaseFileFolder = parentBaseFileFolder + "/executable_files"
+ javaBaseFileFolder = "executable_files"
javaExecutableFileExtension = "java"
javaCompiledFileExtension = "class"
)
// newJavaLifeCycle creates LifeCycle with java SDK environment.
-func newJavaLifeCycle(pipelineId uuid.UUID) *LifeCycle {
- baseFileFolder := fmt.Sprintf("%s_%s", javaBaseFileFolder, pipelineId)
+func newJavaLifeCycle(pipelineId uuid.UUID, workingDir string) *LifeCycle {
+ baseFileFolder := fmt.Sprintf("%s/%s/%s", workingDir,
javaBaseFileFolder, pipelineId)
Review comment:
Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 668863)
Time Spent: 1h (was: 50m)
> [Playground] Using working directory from environment in LifeCycle instead of
> using hardcoded backend directory
> ---------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-13095
> URL: https://issues.apache.org/jira/browse/BEAM-13095
> Project: Beam
> Issue Type: Bug
> Components: beam-playground
> Reporter: Aydar Zaynutdinov
> Assignee: Aydar Zaynutdinov
> Priority: P3
> Labels: beam-playground-backend, beam-playground-sprint-2
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Now _LifeCycle_ uses the _backend_ directory as a root folder. Need to use
> the directory from the received parameter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
