[
https://issues.apache.org/jira/browse/BEAM-12730?focusedWorklogId=669491&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-669491
]
ASF GitHub Bot logged work on BEAM-12730:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Oct/21 12:24
Start Date: 25/Oct/21 12:24
Worklog Time Spent: 10m
Work Description: nikie commented on a change in pull request #15775:
URL: https://github.com/apache/beam/pull/15775#discussion_r735545870
##########
File path: sdks/python/apache_beam/io/textio.py
##########
@@ -172,7 +172,12 @@ def split_points_unclaimed(stop_position):
# belongs to the current bundle, hence ignoring that is incorrect.
# Seeking to one byte before prevents that.
- file_to_read.seek(start_offset - 1)
+ if self._delimiter is not None and start_offset >=
len(self._delimiter):
Review comment:
Can we add a test for this case?
I could not find tests in `textio_test.py` which split the data into
multiple bundles.
But there are test in `filebasedsource_test.py` which do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 669491)
Time Spent: 11.5h (was: 11h 20m)
> Add custom delimiters to Python TextIO reads
> --------------------------------------------
>
> Key: BEAM-12730
> URL: https://issues.apache.org/jira/browse/BEAM-12730
> Project: Beam
> Issue Type: New Feature
> Components: io-py-common, io-py-files
> Reporter: Daniel Oliveira
> Assignee: Dmitrii Kuzin
> Priority: P2
> Labels: beginner, newbie, starter
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> A common request by users is to be able to separate a text files read by
> TextIO with delimiters other than newline. The Java SDK already supports this
> feature.
> The current delimiter code is [located
> here|https://github.com/apache/beam/blob/v2.31.0/sdks/python/apache_beam/io/textio.py#L236]
> and defaults to newlines. This function could easily be modified to also
> handle custom delimiters. Changing this would also necessitate changing the
> API for the various TextIO.Read methods and adding documentation.
> This seems like a good starter bug for making more in-depth contributions to
> Beam Python.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
