[
https://issues.apache.org/jira/browse/BEAM-12818?focusedWorklogId=669525&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-669525
]
ASF GitHub Bot logged work on BEAM-12818:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Oct/21 13:34
Start Date: 25/Oct/21 13:34
Worklog Time Spent: 10m
Work Description: scwhittle commented on pull request #15416:
URL: https://github.com/apache/beam/pull/15416#issuecomment-950935938
R: @chamikaramj PTAL, I believe this addresses the test failures.
The test failures were arising due to the test not specifying a temporary
directory for output. The default behavior in this case is to use the output
directory as the temporary directory. This didn't work with the previous cl
because the temporary files themselves showed up in the output directory then.
I modified the PR so that we continue to use a subdirectory for temporary files
when we were before, what changes is if that subdirectory is unique for the
execution or if it is consistent across executions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 669525)
Time Spent: 3h 50m (was: 3h 40m)
> When writing to GCS, spread prefix of temporary files and reuse autoscaling
> of the temporary directory
> ------------------------------------------------------------------------------------------------------
>
> Key: BEAM-12818
> URL: https://issues.apache.org/jira/browse/BEAM-12818
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Reporter: Sam Whittle
> Assignee: Sam Whittle
> Priority: P1
> Fix For: 2.35.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> When writing files using FileIO, the given temporary directory has a
> subdirectory created in it for each FileBasedSink. This is useful for
> non-windowed output where the temporary directory can be matched to delete
> leftover files that were lost during processing.
> However for windowed writes such subdirectories are unnecessary and cause a
> common prefix to be shared for the temporary files. Additionally this common
> prefix varies per job and thus the autoscaling for the previous prefix is no
> longer effective, see
> https://cloud.google.com/storage/docs/request-rate#randomness_after_sequential_prefixes_is_not_as_effective
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
