[ 
https://issues.apache.org/jira/browse/BEAM-6851?focusedWorklogId=214906&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214906
 ]

ASF GitHub Bot logged work on BEAM-6851:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Mar/19 17:46
            Start Date: 18/Mar/19 17:46
    Worklog Time Spent: 10m 
      Work Description: kyle-winkelman commented on issue #8079: [BEAM-6851] 
Support recursive globs in HadoopFileSystem.
URL: https://github.com/apache/beam/pull/8079#issuecomment-474028065
 
 
   I am currently using a Set to eliminate duplicate Metadata. This means that 
this match could potentially return two Metadata with the same URI but 
different sizeBytes and lastModifiedMillis.
   
   As far as I am aware there is no use case where someone would change an 
existing file so I believe this is an acceptable implementation, just thought I 
would bring this to the attention of the reviewers.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 214906)
    Time Spent: 0.5h  (was: 20m)

> HadoopFileSystem doesn't Support Recursive Globs (**)
> -----------------------------------------------------
>
>                 Key: BEAM-6851
>                 URL: https://issues.apache.org/jira/browse/BEAM-6851
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-hadoop
>            Reporter: Kyle Winkelman
>            Priority: Minor
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The LocalFileSystem supports recursive globs, **, through use of the [glob 
> syntax|https://docs.oracle.com/javase/tutorial/essential/io/fileOps.html#glob]
>  and it would be nice to similarly allow it in the HadoopFileSystem.
> The FileSystem docs say:
> {code:java}
> All FileSystem implementations should support glob in the final hierarchical 
> path component of ResourceIdT. This allows SDK libraries to construct file 
> system agnostic spec. FileSystems can support additional patterns for 
> user-provided specs.
> {code}
> This clearly points out that recursive globs aren't required but may be 
> supported as an additional pattern for user-provided specs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to