[
https://issues.apache.org/jira/browse/BEAM-13021?focusedWorklogId=670436&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-670436
]
ASF GitHub Bot logged work on BEAM-13021:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Oct/21 00:39
Start Date: 27/Oct/21 00:39
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#15692:
URL: https://github.com/apache/beam/pull/15692#discussion_r737019756
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -572,7 +572,8 @@ def _stage_resources(self, pipeline, options):
raise RuntimeError('The --temp_location option must be specified.')
resources = []
- hashes = {}
+ path_hashes = {}
Review comment:
I still don't understand why we need to de-dup using path in addition to
the hash. How can two artifacts that have the same path not have the same hash
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 670436)
Time Spent: 3.5h (was: 3h 20m)
> Deduplicate Python artifact not only by hash but also by source path
> --------------------------------------------------------------------
>
> Key: BEAM-13021
> URL: https://issues.apache.org/jira/browse/BEAM-13021
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Deduplicate Python artifact not only by hash but also by source path
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
