[
https://issues.apache.org/jira/browse/BEAM-12730?focusedWorklogId=670574&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-670574
]
ASF GitHub Bot logged work on BEAM-12730:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Oct/21 08:57
Start Date: 27/Oct/21 08:57
Worklog Time Spent: 10m
Work Description: dmitriikuzinepam commented on pull request #15775:
URL: https://github.com/apache/beam/pull/15775#issuecomment-952693150
> > > We also need to think about self-overlapping delimiters, restricted in
Java SDK. The easiest way would be to also restrict them here (see the ticket's
comment).
> >
> >
> > Let's do it in other ticket, because current ticket is becoming to long
>
> This is already done in this commit:
[bc18afe](https://github.com/apache/beam/commit/bc18afe74636a48c04396483f51caa152320737e)
Without this using self-overlapping delimiter would cause very rare data loss
issues. And introducing this change after custom delimiter feature is released
would mean backward incompatible changes.
I have merged to my PR, thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 670574)
Time Spent: 16h 40m (was: 16.5h)
> Add custom delimiters to Python TextIO reads
> --------------------------------------------
>
> Key: BEAM-12730
> URL: https://issues.apache.org/jira/browse/BEAM-12730
> Project: Beam
> Issue Type: New Feature
> Components: io-py-common, io-py-files
> Reporter: Daniel Oliveira
> Assignee: Dmitrii Kuzin
> Priority: P2
> Labels: beginner, newbie, starter
> Time Spent: 16h 40m
> Remaining Estimate: 0h
>
> A common request by users is to be able to separate a text files read by
> TextIO with delimiters other than newline. The Java SDK already supports this
> feature.
> The current delimiter code is [located
> here|https://github.com/apache/beam/blob/v2.31.0/sdks/python/apache_beam/io/textio.py#L236]
> and defaults to newlines. This function could easily be modified to also
> handle custom delimiters. Changing this would also necessitate changing the
> API for the various TextIO.Read methods and adding documentation.
> This seems like a good starter bug for making more in-depth contributions to
> Beam Python.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
