[ 
https://issues.apache.org/jira/browse/BEAM-11986?focusedWorklogId=671120&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-671120
 ]

ASF GitHub Bot logged work on BEAM-11986:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Oct/21 23:44
            Start Date: 27/Oct/21 23:44
    Worklog Time Spent: 10m 
      Work Description: pabloem commented on a change in pull request #15294:
URL: https://github.com/apache/beam/pull/15294#discussion_r737922502



##########
File path: sdks/python/apache_beam/io/gcp/experimental/spannerio_read_it_test.py
##########
@@ -130,6 +130,9 @@ def test_read_via_sql(self):
 
   @pytest.mark.it_postcommit
   def test_transaction_table_metrics_ok_call(self):
+    if self.runner_name != 'SwitchingDirectRunner':

Review comment:
       maybe `'DirectRunner' in self.runner_name`? Since 
`SwitchingDirectRunner` is not an official name, so it may change in the future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 671120)
    Time Spent: 18.5h  (was: 18h 20m)

> Python Spanner - Implement IO Request Count metric
> --------------------------------------------------
>
>                 Key: BEAM-11986
>                 URL: https://issues.apache.org/jira/browse/BEAM-11986
>             Project: Beam
>          Issue Type: Test
>          Components: io-py-gcp
>            Reporter: Alex Amato
>            Priority: P3
>          Time Spent: 18.5h
>  Remaining Estimate: 0h
>
> Reference PRs (See BigQuery IO example) and detailed explanation of what's 
> needed to instrument this IO with Request Count metrics is found in this 
> handoff doc:
> [https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'|https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'?authuser=0]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to