[
https://issues.apache.org/jira/browse/BEAM-13001?focusedWorklogId=671494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-671494
]
ASF GitHub Bot logged work on BEAM-13001:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Oct/21 15:08
Start Date: 28/Oct/21 15:08
Worklog Time Spent: 10m
Work Description: riteshghorse commented on a change in pull request
#15657:
URL: https://github.com/apache/beam/pull/15657#discussion_r738491007
##########
File path: sdks/go/pkg/beam/core/metrics/metrics.go
##########
@@ -136,6 +136,10 @@ func SetPTransformID(ctx context.Context, id string)
context.Context {
// Checking for *beamCtx is an optimization, so we don't dig deeply
// for ids if not necessary.
if bctx, ok := ctx.(*beamCtx); ok {
+ if _, ok := bctx.store.stateRegistry[id]; !ok {
+ bctx.store.stateRegistry[id] =
[4]*ExecutionState{&ExecutionState{}, &ExecutionState{}, &ExecutionState{},
&ExecutionState{}}
Review comment:
Other function will make a copy of it and the original registry won't
store the written values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 671494)
Time Spent: 5h 40m (was: 5.5h)
> DoFn Execution time metrics (msecs) for Go SDK
> ----------------------------------------------
>
> Key: BEAM-13001
> URL: https://issues.apache.org/jira/browse/BEAM-13001
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Ritesh Ghorse
> Assignee: Ritesh Ghorse
> Priority: P2
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> Implement DoFn execution time metrics for Go SDK.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
