[
https://issues.apache.org/jira/browse/BEAM-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795617#comment-16795617
]
Kenneth Knowles commented on BEAM-987:
--------------------------------------
Strongly disagree. Advancing the watermark to infinity happens at a particular
instant of processing time. It is a thing that happens in real pipelines when
an unbounded source discovers that it is finite.
> TestStream.advanceWatermarkToInfinity should perhaps also advance processing
> time
> ---------------------------------------------------------------------------------
>
> Key: BEAM-987
> URL: https://issues.apache.org/jira/browse/BEAM-987
> Project: Beam
> Issue Type: Improvement
> Components: runner-direct, testing
> Reporter: Eugene Kirpichov
> Priority: Major
> Labels: starter
>
> I ran into this when writing a test for Splittable DoFn whose input was a
> TestStream. I constructed a TestStream that didn't call
> advanceProcessingTime, and as a result, the SDF's timers didn't fire and the
> test got stuck.
> I think the meaning of "advanceWatermarkToInfinity" is "don't add any more
> elements to the stream and see what happens eventually", and "eventually"
> includes "eventually in processing time domain", not just in event-time
> domain (watermark).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
