[
https://issues.apache.org/jira/browse/BEAM-12730?focusedWorklogId=672093&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-672093
]
ASF GitHub Bot logged work on BEAM-12730:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/21 17:52
Start Date: 29/Oct/21 17:52
Worklog Time Spent: 10m
Work Description: tvalentyn edited a comment on pull request #15775:
URL: https://github.com/apache/beam/pull/15775#issuecomment-954919090
> No, the '\r' would not get appended to the input.
> I checked the case next code, read text without any transformation, only
try to find extra symbol '\r'
Thanks for the snippet. The case i was concerned about is where we use a
default separator (evaluates to \n), but split between '\r\n', not a custom
separator that is also \r\n. I checked that it also works, since we just extend
the buffer, and then still look back 1 character when we encounter \n.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 672093)
Time Spent: 19h 20m (was: 19h 10m)
> Add custom delimiters to Python TextIO reads
> --------------------------------------------
>
> Key: BEAM-12730
> URL: https://issues.apache.org/jira/browse/BEAM-12730
> Project: Beam
> Issue Type: New Feature
> Components: io-py-common, io-py-files
> Reporter: Daniel Oliveira
> Assignee: Dmitrii Kuzin
> Priority: P2
> Labels: beginner, newbie, starter
> Time Spent: 19h 20m
> Remaining Estimate: 0h
>
> A common request by users is to be able to separate a text files read by
> TextIO with delimiters other than newline. The Java SDK already supports this
> feature.
> The current delimiter code is [located
> here|https://github.com/apache/beam/blob/v2.31.0/sdks/python/apache_beam/io/textio.py#L236]
> and defaults to newlines. This function could easily be modified to also
> handle custom delimiters. Changing this would also necessitate changing the
> API for the various TextIO.Read methods and adding documentation.
> This seems like a good starter bug for making more in-depth contributions to
> Beam Python.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
