[
https://issues.apache.org/jira/browse/BEAM-2791?focusedWorklogId=674326&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-674326
]
ASF GitHub Bot logged work on BEAM-2791:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Nov/21 02:32
Start Date: 03/Nov/21 02:32
Worklog Time Spent: 10m
Work Description: reuvenlax commented on a change in pull request #15810:
URL: https://github.com/apache/beam/pull/15810#discussion_r741580687
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/FakeDatasetService.java
##########
@@ -249,7 +254,21 @@ public void createTable(Table table) throws IOException {
"Tried to get a dataset %s:%s, but no such table was set",
tableReference.getProjectId(), tableReference.getDatasetId());
}
- dataset.computeIfAbsent(tableReference.getTableId(), k -> new
TableContainer(table));
+ dataset.computeIfAbsent(
+ tableReference.getTableId(),
+ k -> {
+ TableContainer tableContainer = new TableContainer(table);
+ // Create the default stream.
+ String streamName =
+ String.format(
+ "projects/%s/datasets/%s/tables/%s/streams/_default",
+ tableReference.getProjectId(),
+ tableReference.getDatasetId(),
+
BigQueryHelpers.stripPartitionDecorator(tableReference.getTableId()));
+ writeStreams.put(streamName, new Stream(tableContainer,
Type.COMMITTED));
Review comment:
This is just the unit-testing fake though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 674326)
Time Spent: 2h 50m (was: 2h 40m)
> DirectRunner shuts down when there are pending event time timers
> ----------------------------------------------------------------
>
> Key: BEAM-2791
> URL: https://issues.apache.org/jira/browse/BEAM-2791
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Kenneth Knowles
> Priority: P3
> Labels: sickbay
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> When there are pending event time timers for a window by definition they are
> within the window so it should not be possible to GC the window nor to shut
> down the pipeline.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
