[
https://issues.apache.org/jira/browse/BEAM-13119?focusedWorklogId=674793&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-674793
]
ASF GitHub Bot logged work on BEAM-13119:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Nov/21 17:35
Start Date: 03/Nov/21 17:35
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #15881:
URL: https://github.com/apache/beam/pull/15881#issuecomment-959765295
#
[Codecov](https://codecov.io/gh/apache/beam/pull/15881?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#15881](https://codecov.io/gh/apache/beam/pull/15881?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a79d493) into
[master](https://codecov.io/gh/apache/beam/commit/526359b27e61463c5b9b2fa86d9ba23ed5890f3e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(526359b) will **increase** coverage by `0.01%`.
> The diff coverage is `97.18%`.
[](https://codecov.io/gh/apache/beam/pull/15881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15881 +/- ##
==========================================
+ Coverage 83.49% 83.51% +0.01%
==========================================
Files 445 445
Lines 61305 61365 +60
==========================================
+ Hits 51189 51251 +62
+ Misses 10116 10114 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/15881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/15881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==)
| `94.87% <95.23%> (+<0.01%)` | :arrow_up: |
|
[sdks/python/apache\_beam/io/textio.py](https://codecov.io/gh/apache/beam/pull/15881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vdGV4dGlvLnB5)
| `97.35% <100.00%> (+0.25%)` | :arrow_up: |
|
[...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/15881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==)
| `78.26% <0.00%> (-1.45%)` | :arrow_down: |
|
[...runners/interactive/display/pcoll\_visualization.py](https://codecov.io/gh/apache/beam/pull/15881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3Bjb2xsX3Zpc3VhbGl6YXRpb24ucHk=)
| `86.36% <0.00%> (+0.50%)` | :arrow_up: |
|
[...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/15881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5)
| `76.58% <0.00%> (+0.97%)` | :arrow_up: |
|
[...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/15881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==)
| `96.26% <0.00%> (+2.23%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/15881?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/15881?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[48318dd...a79d493](https://codecov.io/gh/apache/beam/pull/15881?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 674793)
Time Spent: 0.5h (was: 20m)
> Add subdirectory prefixed tags to release process to support Go SDK
> versioning.
> -------------------------------------------------------------------------------
>
> Key: BEAM-13119
> URL: https://issues.apache.org/jira/browse/BEAM-13119
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> BEAM-5379 updated the SDK to use modules for Dependency management for 2.33.0
> but it isn't behaving as expected. The release versions are being ignored.
> Turns out we misunderstood one facet of having the go.mod file not at the
> root directory: to version that package, version tags must be prefixed with
> the directory path to the go.mod file.
> See https://golang.org/ref/mod#vcs-version for the description.
> We've validated that adding such a prefixed tag to a release branch resolves
> the issue.
> https://pkg.go.dev/github.com/apache/beam/sdks/[email protected]/go/pkg/beam?tab=versions
> This JIRA is to track adding the version tags to the release processes so we
> can continue paired releases for all SDKs, and back updating 2.33.0 with a
> tag so we can keep it as the first "non-experimental" release.
> Further discussion:
> https://lists.apache.org/thread.html/r987ea3540a0457ede258a96a0748b9af39c1de0acd83e822de8d0abb%40%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
