[
https://issues.apache.org/jira/browse/BEAM-12313?focusedWorklogId=675253&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675253
]
ASF GitHub Bot logged work on BEAM-12313:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 00:33
Start Date: 04/Nov/21 00:33
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#15675:
URL: https://github.com/apache/beam/pull/15675#discussion_r742132102
##########
File path:
sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/jvmverification/JvmVerification.java
##########
@@ -55,6 +54,11 @@ public void verifyTestCodeIsCompiledWithJava11() throws
IOException {
assertEquals(v11, getByteCodeVersion(JvmVerification.class));
}
+ @Test
+ public void verifyTestCodeIsCompiledWithJava17() throws IOException {
+ assertEquals(v17, getByteCodeVersion(JvmVerification.class));
Review comment:
Need to add an entry to `versionMapping`, right?
##########
File path:
sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/jvmverification/JvmVerification.java
##########
@@ -55,6 +54,11 @@ public void verifyTestCodeIsCompiledWithJava11() throws
IOException {
assertEquals(v11, getByteCodeVersion(JvmVerification.class));
}
+ @Test
+ public void verifyTestCodeIsCompiledWithJava17() throws IOException {
+ assertEquals(v17, getByteCodeVersion(JvmVerification.class));
Review comment:
Need to add an entry to `versionMapping`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 675253)
Time Spent: 7h 40m (was: 7.5h)
> Publish Java 17 SDK Harness docker image
> ----------------------------------------
>
> Key: BEAM-12313
> URL: https://issues.apache.org/jira/browse/BEAM-12313
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, sdk-java-harness
> Reporter: Ismaël Mejía
> Assignee: Fernando Morales
> Priority: P3
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
