[
https://issues.apache.org/jira/browse/BEAM-13187?focusedWorklogId=675918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675918
]
ASF GitHub Bot logged work on BEAM-13187:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 01:40
Start Date: 04/Nov/21 01:40
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#15889:
URL: https://github.com/apache/beam/pull/15889#discussion_r742424001
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -670,7 +670,8 @@ def __enter__(self):
self._service_provider = subprocess_server.JavaJarServer(
ExpansionAndArtifactRetrievalStub,
self._path_to_jar,
- self._extra_args)
+ self._extra_args + [f'--filesToStage={self._path_to_jar}'],
Review comment:
The behavior is a little different here. We set `--filesToStage` even if
extra_args was not None in `__init__`. I'm not sure if the previous behavior
was intentional or not.
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -670,7 +670,8 @@ def __enter__(self):
self._service_provider = subprocess_server.JavaJarServer(
ExpansionAndArtifactRetrievalStub,
self._path_to_jar,
- self._extra_args)
+ self._extra_args + [f'--filesToStage={self._path_to_jar}'],
Review comment:
The behavior is a little different here. We set `--filesToStage` even if
`extra_args` was not None in `__init__`. I'm not sure if the previous behavior
was intentional or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 675918)
Time Spent: 3h 50m (was: 3h 40m)
> BeamJarExpansionService fails to stage remote artifacts
> -------------------------------------------------------
>
> Key: BEAM-13187
> URL: https://issues.apache.org/jira/browse/BEAM-13187
> Project: Beam
> Issue Type: Bug
> Components: cross-language, sdk-py-core
> Reporter: Brian Hulette
> Assignee: Robert Bradshaw
> Priority: P1
> Fix For: 2.34.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> See https://github.com/apache/beam/pull/15638/files#r742413302
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
