[
https://issues.apache.org/jira/browse/BEAM-11205?focusedWorklogId=675971&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675971
]
ASF GitHub Bot logged work on BEAM-11205:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 01:46
Start Date: 04/Nov/21 01:46
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#15835:
URL: https://github.com/apache/beam/pull/15835#discussion_r742158390
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/util/ApiSurface.java
##########
@@ -712,11 +712,18 @@ private void addExposedTypes(Class<?> clazz, Class<?>
cause) {
private void addExposedTypes(Invokable<?, ?> invokable, Class<?> cause) {
addExposedTypes(invokable.getReturnType(), cause);
for (Annotation annotation : invokable.getAnnotations()) {
+ Class<? extends Annotation> annotationClass =
annotation.annotationType();
+ if (!Modifier.isPublic(annotationClass.getModifiers())) {
+ // Non-public annotations are invisible to Beam users. Example: Guava's
+ // ParametricNullness is package-private and exists to support Kotlin
platform
Review comment:
Interesting! Definitely relevant beyond Kotlin (for example
https://checkerframework.org/releases/0.9.7/doc/checkers/nullness/quals/PolyNull.html)
but your change is more general and obviously correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 675971)
Time Spent: 67h 50m (was: 67h 40m)
> Beam Dependency Update Request: com.google.cloud:libraries-bom
> --------------------------------------------------------------
>
> Key: BEAM-11205
> URL: https://issues.apache.org/jira/browse/BEAM-11205
> Project: Beam
> Issue Type: Sub-task
> Components: dependencies
> Reporter: Beam JIRA Bot
> Assignee: Tomo Suzuki
> Priority: P3
> Time Spent: 67h 50m
> Remaining Estimate: 0h
>
> ------------------------- 2020-11-09 12:16:08.172595
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 15.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-11-16 12:18:49.798793
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 15.1.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-11-23 12:19:51.199039
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.1.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-11-30 12:17:29.500873
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.1.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-12-07 12:21:08.748853
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.1.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-12-14 12:29:04.542548
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.1.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-12-21 12:19:36.603441
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.2.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-12-28 12:18:16.249769
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.2.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-01-04 12:18:36.130621
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.2.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-01-11 12:19:38.435168
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.2.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-01-18 12:39:57.569136
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.3.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-01-25 12:21:43.434396
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.3.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-02-01 12:21:46.860882
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.3.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-02-08 12:25:15.112066
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.3.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-02-15 12:22:57.783575
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.4.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-01 12:21:19.025373
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 18.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-08 12:23:06.962620
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 19.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-15 12:24:46.684593
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 19.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-22 12:22:22.770376
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 19.2.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-29 12:22:10.157690
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 19.2.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-04-05 12:23:32.502855
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 19.2.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-04-12 12:24:46.306174
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 19.2.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-04-19 12:23:16.380975
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 20.1.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-05-17 12:21:31.032271
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 20.4.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-05-24 12:21:44.236302
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 20.4.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-05-31 12:22:53.457542
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 20.5.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-06-08 17:21:56.446842
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 20.6.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-06-14 12:25:58.931754
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 20.6.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-06-21 12:23:28.700951
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 20.6.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-06-28 12:22:51.713714
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 20.7.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-07-05 12:25:16.696028
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 20.7.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-07-19 12:24:47.040882
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 20.8.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-07-26 12:24:16.691432
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 20.9.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-08-02 12:23:20.383266
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 20.9.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-08-09 12:31:50.557441
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 20.9.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-08-16 12:28:04.774560
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 20.9.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-08-23 12:35:28.652297
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 21.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-08-30 12:28:57.081183
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 22.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-09-06 12:28:58.661692
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 20.0.0. The latest version is 22.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-09-13 12:28:01.878640
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 22.0.0. The latest version is 23.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-09-20 12:23:06.851477
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 22.0.0. The latest version is 23.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-09-27 12:23:50.987489
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 22.0.0. The latest version is 23.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-10-04 12:28:04.347122
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 22.0.0. The latest version is 23.1.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-10-11 12:23:28.102380
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 22.0.0. The latest version is 23.1.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
