[
https://issues.apache.org/jira/browse/BEAM-13192?focusedWorklogId=677077&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-677077
]
ASF GitHub Bot logged work on BEAM-13192:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/21 16:07
Start Date: 05/Nov/21 16:07
Worklog Time Spent: 10m
Work Description: mosche commented on a change in pull request #15910:
URL: https://github.com/apache/beam/pull/15910#discussion_r743782615
##########
File path:
sdks/java/io/amazon-web-services/src/test/java/org/apache/beam/sdk/io/aws/sns/SnsIOTest.java
##########
@@ -114,7 +118,10 @@ public void testDataWritesToSNS() {
@Test
public void testRetries() throws Throwable {
+ thrown.expect(IOException.class);
Review comment:
No, it's just important to not accept any Exception. Otherwise the
AssertionError thrown by `snsWriterFnLogs.verifyWarn` fullfills this, which is
kind of pointless. But that's exactly what happened, because logs for the wrong
logger were captured.
Even more, the message of the assertion error contained exactly that string
we expected to be thrown because it's also the string we were checking for in
the logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 677077)
Time Spent: 1h 10m (was: 1h)
> Tests for retries in SnsIO.Writer are buggy
> -------------------------------------------
>
> Key: BEAM-13192
> URL: https://issues.apache.org/jira/browse/BEAM-13192
> Project: Beam
> Issue Type: Bug
> Components: io-java-aws
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P3
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> There's no working verification that retries happened.
> All assertions fail in unforeseen / unintended ways.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
