[
https://issues.apache.org/jira/browse/BEAM-6257?focusedWorklogId=215772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215772
]
ASF GitHub Bot logged work on BEAM-6257:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/19 21:30
Start Date: 19/Mar/19 21:30
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #8094: [BEAM-6257]
PAssert.thatSingleton: use GBK instead of side inputs
URL: https://github.com/apache/beam/pull/8094
Pretty straightforward change, but useful as my Spark prototype does not yet
support side inputs. Accomplished by loosening the type restrictions on the
existing but heretofore misleadingly-named `GroupThenAssertForSingleton`. I'll
leave `thatMap` and `thatMultimap` for later.
R: @kennknowles
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 215772)
Time Spent: 10m
Remaining Estimate: 0h
> Can we deprecate the side input paths through PAssert?
> ------------------------------------------------------
>
> Key: BEAM-6257
> URL: https://issues.apache.org/jira/browse/BEAM-6257
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Major
> Labels: starter, triaged
> Time Spent: 10m
> Remaining Estimate: 0h
>
> PAssert has two distinct paths - one uses GBK with a single-firing trigger,
> and one uses side inputs. Side inputs are usually a later addition to a
> runner, while GBK is one of the first primitives (with a single firing it is
> even simple). Filing this against myself to figure out why the side input
> version is not deprecated, and if it can be deprecated.
> Marking this as a "starter" task because finding and eliminating side input
> version of PAssert should be fairly easy. You might need help but can ask on
> dev@
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
