[
https://issues.apache.org/jira/browse/BEAM-13147?focusedWorklogId=679174&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-679174
]
ASF GitHub Bot logged work on BEAM-13147:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/21 17:05
Start Date: 09/Nov/21 17:05
Worklog Time Spent: 10m
Work Description: mosche commented on a change in pull request #15843:
URL: https://github.com/apache/beam/pull/15843#discussion_r745826518
##########
File path:
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/options/AwsModule.java
##########
@@ -112,7 +112,9 @@ public AWSCredentialsProvider deserializeWithType(
JsonParser jsonParser, DeserializationContext context,
TypeDeserializer typeDeserializer)
throws IOException {
Map<String, String> asMap =
- jsonParser.readValueAs(new TypeReference<Map<String, String>>() {});
+ checkNotNull(
Review comment:
In this case `checkNotNull` is fine 🤯
I don't get it why strings are treated differently by checker
##########
File path:
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/options/AwsModule.java
##########
@@ -112,7 +112,9 @@ public AWSCredentialsProvider deserializeWithType(
JsonParser jsonParser, DeserializationContext context,
TypeDeserializer typeDeserializer)
throws IOException {
Map<String, String> asMap =
- jsonParser.readValueAs(new TypeReference<Map<String, String>>() {});
+ checkNotNull(
Review comment:
I'm tempted to just reenable `@SuppressWarnings({"nullness"})` for the
entire class 😳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 679174)
Time Spent: 1h 40m (was: 1.5h)
> Eliminate nullability errors from :sdks:java:io:aws(2) AwsModule
> ----------------------------------------------------------------
>
> Key: BEAM-13147
> URL: https://issues.apache.org/jira/browse/BEAM-13147
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-aws
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P3
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
