[
https://issues.apache.org/jira/browse/BEAM-12883?focusedWorklogId=679254&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-679254
]
ASF GitHub Bot logged work on BEAM-12883:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/21 19:06
Start Date: 09/Nov/21 19:06
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #15699:
URL: https://github.com/apache/beam/pull/15699#issuecomment-964449526
This is pretty cool. Thanks @brachi-wernick !
I think it makes sense to create a JIRA issue with target version 3.0.0 to
remove the V1 and V2 coders, and rely directly on the latest versions of these
coders. WDYT?
I will ask someone who knows coders better to verify that this coder
implementation is backwards-compatible for the addition of new fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 679254)
Time Spent: 4h (was: 3h 50m)
> FileSystems ReadableFileCoder should support Metadata#lastModifiedMillis()
> --------------------------------------------------------------------------
>
> Key: BEAM-12883
> URL: https://issues.apache.org/jira/browse/BEAM-12883
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Brachi Packter
> Assignee: Brachi Packter
> Priority: P3
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Currently, there is a separated coder for Metadata which cares about
> `Metadata#lastModifiedMillis()`.
> The issue is that the `ReadableFileCoder` always uses the default `Metadata`
> coder.
> We need to create a similar coder for `ReadableFileCoder`:
> ``ReadableFileCoderV2` which just use the corresponding `MetadataCoderV2`.
> Without doing so `lastModifiedMillis` will remain zero.
> There is also no way to create custom coder in our side since
> `FileIO.ReadableFile` has no public method to initiate new instance of it.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
