[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=679962&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-679962
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/21 21:38
Start Date: 10/Nov/21 21:38
Worklog Time Spent: 10m
Work Description: benWize commented on a change in pull request #15742:
URL: https://github.com/apache/beam/pull/15742#discussion_r747005290
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/common/worker/MapTaskExecutor.java
##########
@@ -72,9 +69,7 @@ public void execute() throws Exception {
// Save the current thread that is executing so that abort() can interrupt
it, we save it before
// starting the progress reporter thread, therefore ensuring thread safety
through implicit
// serialization of events.
- synchronized (this) {
- this.currentExecutorThread = Thread.currentThread();
- }
+ // Current thread that execute() is running on; null when not running.
Review comment:
Removed
##########
File path:
examples/java/src/main/java/org/apache/beam/examples/cookbook/JoinExamples.java
##########
@@ -93,7 +93,7 @@
public void processElement(ProcessContext c) {
KV<String, CoGbkResult> e = c.element();
String countryCode = e.getKey();
- String countryName = "none";
+ String countryName;
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 679962)
Time Spent: 29h 20m (was: 29h 10m)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 29h 20m
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
