[ 
https://issues.apache.org/jira/browse/BEAM-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441991#comment-17441991
 ] 

Robert Burke commented on BEAM-13142:
-------------------------------------

Timers aren't supported yet in the Go SDK, but the Data error seems to be easy 
enough to fix. I'll make a subtask for it.

> Ensure that the payload is consumed on Elements.Data and Elements.Timers when 
> is_last = true
> --------------------------------------------------------------------------------------------
>
>                 Key: BEAM-13142
>                 URL: https://issues.apache.org/jira/browse/BEAM-13142
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-go, sdk-java-harness, sdk-py-harness
>            Reporter: Luke Cwik
>            Priority: P2
>
> BeamFnDataInboundObserver drops the bytes instead of passing it forward on 
> the last message: 
> https://github.com/apache/beam/blob/cd4b7f3b1af4f51bdab1a0b1a98f94b5288c09ec/sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataInboundObserver.java#L58
> data_plane.py drops the timers payload but seems to do the right thing for 
> data:
> https://github.com/apache/beam/blob/cd4b7f3b1af4f51bdab1a0b1a98f94b5288c09ec/sdks/python/apache_beam/runners/worker/data_plane.py#L343
> data_mgr.go drops the data payload (timers don't seem to be supported):
> https://github.com/apache/beam/blob/cd4b7f3b1af4f51bdab1a0b1a98f94b5288c09ec/sdks/go/pkg/beam/core/runtime/harness/datamgr.go#L297



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to