[
https://issues.apache.org/jira/browse/BEAM-13081?focusedWorklogId=680047&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-680047
]
ASF GitHub Bot logged work on BEAM-13081:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/21 23:48
Start Date: 10/Nov/21 23:48
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #15938:
URL: https://github.com/apache/beam/pull/15938#issuecomment-965841492
#
[Codecov](https://codecov.io/gh/apache/beam/pull/15938?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#15938](https://codecov.io/gh/apache/beam/pull/15938?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(f45c714) into
[master](https://codecov.io/gh/apache/beam/commit/03d4e42520070b304eed05da6f076c758653ca7f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(03d4e42) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/15938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15938 +/- ##
==========================================
- Coverage 83.53% 83.53% -0.01%
==========================================
Files 445 445
Lines 61385 61387 +2
==========================================
- Hits 51279 51277 -2
- Misses 10106 10110 +4
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/15938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/15938/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=)
| `90.00% <0.00%> (-1.00%)` | :arrow_down: |
|
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/15938/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
| `93.26% <0.00%> (-0.38%)` | :arrow_down: |
|
[sdks/python/apache\_beam/coders/row\_coder.py](https://codecov.io/gh/apache/beam/pull/15938/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Jvd19jb2Rlci5weQ==)
| `95.13% <0.00%> (+0.06%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/15938?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/15938?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[2f1d780...f45c714](https://codecov.io/gh/apache/beam/pull/15938?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 680047)
Time Spent: 5.5h (was: 5h 20m)
> Portable representation of "packed bitset indicating null fields" in beam Row
> format is not compatible with jvm representations
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-13081
> URL: https://issues.apache.org/jira/browse/BEAM-13081
> Project: Beam
> Issue Type: Bug
> Components: cross-language
> Reporter: Steve Niemitz
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> The JVM RowCoder strips trailing 0s from the null-value bitmap, while both
> python and go expect all bits to be present in the encoded bitmap. This
> causes index-out-of-range errors when trying to decode a row encoded on the
> JVM in other languages in some circumstances.
> For example, given a Row with 10 nullable fields, if the first 8 are null and
> the last two are set, the row will fail to decode in python, because the
> nullable bitmap will only have 1 byte, but the python coder expects 2.
> As discussed in the thread, the best solution here is probably to change the
> python (and go) coders to accept truncated nullable bitmaps.
>
> More discussion here:
> [https://lists.apache.org/thread.html/r2f148e29902bda8bb0ff7106fffb8a5494295450827ad7fd17289383%40%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
