[
https://issues.apache.org/jira/browse/BEAM-13110?focusedWorklogId=680256&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-680256
]
ASF GitHub Bot logged work on BEAM-13110:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/21 12:26
Start Date: 11/Nov/21 12:26
Worklog Time Spent: 10m
Work Description: AydarZaynutdinov commented on a change in pull request
#15926:
URL: https://github.com/apache/beam/pull/15926#discussion_r747424034
##########
File path: playground/backend/cmd/server/controller_test.go
##########
@@ -448,6 +453,58 @@ func TestPlaygroundController_GetRunError(t *testing.T) {
}
}
+func TestPlaygroundController_Cancel(t *testing.T) {
Review comment:
Yes, this is a good point. However, when I tried to use this library for
our tests some tests were failed. It seems that during the processing of the
tests, we are creating additional goroutines (for local storage and to send
requests to the backend), so this library will find them as additional
goroutines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 680256)
Time Spent: 2h (was: 1h 50m)
> [Playground] Playground pipeline cancelation
> --------------------------------------------
>
> Key: BEAM-13110
> URL: https://issues.apache.org/jira/browse/BEAM-13110
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Aydar Zaynutdinov
> Assignee: Aydar Zaynutdinov
> Priority: P3
> Labels: beam-playground-backend
> Time Spent: 2h
> Remaining Estimate: 0h
>
> * Add status Canceled
> * Add new API method Cancel:
> this method should set pipelinedId:canceled:true to cache
> * Update code processing:
> If the pipelinedId:canceled is true, then
> ** set status Canceled
> ** stop processes (which were generated to process code) for pipelineId
> ** clean resources (folders and files to process code) for pipelineId
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
