[
https://issues.apache.org/jira/browse/BEAM-13228?focusedWorklogId=680401&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-680401
]
ASF GitHub Bot logged work on BEAM-13228:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/21 18:16
Start Date: 11/Nov/21 18:16
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #15946:
URL: https://github.com/apache/beam/pull/15946#discussion_r747719324
##########
File path: sdks/go/pkg/beam/core/metrics/store.go
##########
@@ -128,9 +128,11 @@ func (e Extractor) ExtractFrom(store *Store) error {
}
}
if e.MsecsInt64 != nil {
+ store.mu.Lock()
Review comment:
This isn't required, you're already acquiring locks up at the start of
the method. (the RLock & RUnlock since this only reads data, not writes to the
store) That's causing the deadlock failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 680401)
Time Spent: 1h (was: 50m)
> Fix data race in metrics.Store acessing stateRegistry
> -----------------------------------------------------
>
> Key: BEAM-13228
> URL: https://issues.apache.org/jira/browse/BEAM-13228
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Ritesh Ghorse
> Assignee: Ritesh Ghorse
> Priority: P2
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Accessing `store.stateRegistry` in metrics.go and store.go causes data race.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
