Sergey Kalinin created BEAM-13251:
-------------------------------------
Summary: [Playground]Lint Fails on Playground Backend
Key: BEAM-13251
URL: https://issues.apache.org/jira/browse/BEAM-13251
Project: Beam
Issue Type: Bug
Components: beam-playground
Reporter: Sergey Kalinin
GO linter fails with following error:
| cmd/server/controller.go:64:12: Error return value is not checked (errcheck)
| setToCache(ctx, controller.cacheService, pipelineId, cache.Status,
pb.Status_STATUS_VALIDATING)
| ^
| cmd/server/controller.go:333:13: Error return value is not checked (errcheck)
| setToCache(ctxWithTimeout, cacheService, pipelineId,
cache.Status, pb.Status_STATUS_ERROR)
| ^
| cmd/server/controller.go:390:12: Error return value is not checked (errcheck)
| setToCache(ctx, cacheService, pipelineId, cache.Status,
pb.Status_STATUS_RUN_TIMEOUT)
| ^
| cmd/server/controller_test.go:687:27: Error return value of
`cacheService.SetValue` is not checked (errcheck)
| cacheService.SetValue(ctx, pipelineId,
cache.Canceled, true)
| ^
| cmd/server/http.go:31:2: S1000: should use for range instead of for \{ select
{} } (gosimple)
| for \{
| ^
| cmd/server/tcp.go:38:2: S1000: should use for range instead of for { select
{} } (gosimple)
| for {
| ^
| cmd/server/controller.go:404:8: S1005: unnecessary assignment to the blank
identifier (gosimple)
| case _ = <-ticker.C:
| ^
| cmd/server/controller_test.go:112:13: unusedresult: result of fmt.Errorf call
not used (govet)
| fmt.Errorf("error during test setup: %s", err.Error())
| ^
| cmd/server/controller_test.go:51:1: SA3000: TestMain should call os.Exit to
set exit code (staticcheck)
| func TestMain(m *testing.M) {
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
