[
https://issues.apache.org/jira/browse/BEAM-13221?focusedWorklogId=681778&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-681778
]
ASF GitHub Bot logged work on BEAM-13221:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/21 01:18
Start Date: 16/Nov/21 01:18
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #15939:
URL: https://github.com/apache/beam/pull/15939#issuecomment-969596882
> For some reason I would have moved the `if elm.GetIsLast()` to beyond the
existing `select case` but can see that we still want to delete from the cache
and that doesn't play nicely with the existing code layout.
I can't see any reason it shouldn't work, but I don't want to re-reason
through the cache behavior at the moment so I'm hesitant to move it. I feel the
clarity of distinct "this is the last element" handling supersedes
deduplicating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 681778)
Time Spent: 40m (was: 0.5h)
> [Go SDK] Ensure that the payload is consumed on Elements.Data is_last = true
> ----------------------------------------------------------------------------
>
> Key: BEAM-13221
> URL: https://issues.apache.org/jira/browse/BEAM-13221
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> https://github.com/apache/beam/blob/cd4b7f3b1af4f51bdab1a0b1a98f94b5288c09ec/sdks/go/pkg/beam/core/runtime/harness/datamgr.go#L284
> Data (and technically timers) can be present when is_last is true, rather
> than just as a one_of sentinel value.
> https://github.com/apache/beam/blob/cd4b7f3b1af4f51bdab1a0b1a98f94b5288c09ec/model/fn-execution/src/main/proto/beam_fn_api.proto#L520
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
