[
https://issues.apache.org/jira/browse/BEAM-13262?focusedWorklogId=682107&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-682107
]
ASF GitHub Bot logged work on BEAM-13262:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/21 16:58
Start Date: 16/Nov/21 16:58
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #15993:
URL: https://github.com/apache/beam/pull/15993#discussion_r750479823
##########
File path: sdks/go/pkg/beam/forward.go
##########
@@ -215,3 +216,5 @@ var (
// EventTimeType is the reflect.Type of EventTime.
var EventTimeType = typex.EventTimeType
+
Review comment:
Exported types, even type aliases, require their own doc comment.
// MetricResult represents a single metric value, for use in writing
predicate functions to query PipelineResults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 682107)
Time Spent: 0.5h (was: 20m)
> Forward for metrics.SingleResult
> --------------------------------
>
> Key: BEAM-13262
> URL: https://issues.apache.org/jira/browse/BEAM-13262
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Ritesh Ghorse
> Assignee: Ritesh Ghorse
> Priority: P3
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Create a simple forward for
> [metrics.SingleResult|https://github.com/apache/beam/blob/31af8e5e3e4af8ad269958f765c29970114ed288/sdks/go/pkg/beam/core/metrics/metrics.go#L521]
> into
> [forward.go|https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/forward.go]
> so that users don't have to import internal package to query results.
> Thanks [~lostluck] for the suggestion!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
