[
https://issues.apache.org/jira/browse/BEAM-13251?focusedWorklogId=682168&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-682168
]
ASF GitHub Bot logged work on BEAM-13251:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/21 18:16
Start Date: 16/Nov/21 18:16
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #15991:
URL: https://github.com/apache/beam/pull/15991#issuecomment-970537774
oops sorry I guess we need to fix conflicts here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 682168)
Time Spent: 40m (was: 0.5h)
> [Playground] Lint Fails on Playground Backend
> ----------------------------------------------
>
> Key: BEAM-13251
> URL: https://issues.apache.org/jira/browse/BEAM-13251
> Project: Beam
> Issue Type: Bug
> Components: beam-playground
> Reporter: Sergey Kalinin
> Assignee: Aydar Zaynutdinov
> Priority: P3
> Labels: beam-playground-backend
> Time Spent: 40m
> Remaining Estimate: 0h
>
> GO linter fails with following error:
> | cmd/server/controller.go:64:12: Error return value is not checked (errcheck)
> | setToCache(ctx, controller.cacheService, pipelineId, cache.Status,
> pb.Status_STATUS_VALIDATING)
> | ^
> | cmd/server/controller.go:333:13: Error return value is not checked
> (errcheck)
> | setToCache(ctxWithTimeout, cacheService, pipelineId,
> cache.Status, pb.Status_STATUS_ERROR)
> | ^
> | cmd/server/controller.go:390:12: Error return value is not checked
> (errcheck)
> | setToCache(ctx, cacheService, pipelineId, cache.Status,
> pb.Status_STATUS_RUN_TIMEOUT)
> | ^
> | cmd/server/controller_test.go:687:27: Error return value of
> `cacheService.SetValue` is not checked (errcheck)
> | cacheService.SetValue(ctx, pipelineId,
> cache.Canceled, true)
> | ^
> | cmd/server/http.go:31:2: S1000: should use for range instead of for \{
> select {} } (gosimple)
> | for \{
> | ^
> | cmd/server/tcp.go:38:2: S1000: should use for range instead of for { select
> {} } (gosimple)
> | for {
> | ^
> | cmd/server/controller.go:404:8: S1005: unnecessary assignment to the blank
> identifier (gosimple)
> | case _ = <-ticker.C:
> | ^
> | cmd/server/controller_test.go:112:13: unusedresult: result of fmt.Errorf
> call not used (govet)
> | fmt.Errorf("error during test setup: %s", err.Error())
> | ^
> | cmd/server/controller_test.go:51:1: SA3000: TestMain should call os.Exit to
> set exit code (staticcheck)
> | func TestMain(m *testing.M) {
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
