[ 
https://issues.apache.org/jira/browse/BEAM-13236?focusedWorklogId=682440&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-682440
 ]

ASF GitHub Bot logged work on BEAM-13236:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Nov/21 08:51
            Start Date: 17/Nov/21 08:51
    Worklog Time Spent: 10m 
      Work Description: mosche commented on pull request #15955:
URL: https://github.com/apache/beam/pull/15955#issuecomment-971364866


   Actually, this is more complicated (broken?) than I thought. Closing the PR 
for now.
   Per JVM a producer is shared among all `KinesisWriterFn`s. Sharing producers 
absolutely makes sense, nevertheless this still leaks. Also, if the static 
instance is reused producer properties might be silently dropped without notice.
   ```
         private static transient IKinesisProducer producer;
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 682440)
    Time Spent: 0.5h  (was: 20m)

> Properly close kinesis producer on teardown
> -------------------------------------------
>
>                 Key: BEAM-13236
>                 URL: https://issues.apache.org/jira/browse/BEAM-13236
>             Project: Beam
>          Issue Type: Task
>          Components: io-java-kinesis
>            Reporter: Moritz Mack
>            Assignee: Moritz Mack
>            Priority: P2
>              Labels: aws, ios, kinesis
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Each KPL producer uses it's own native deamon, so properly cleaning up once 
> not used anymore is important.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to